tutorial step 7/8: improve a11y, teach better practices #1592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's easier, and more accessible, to handle a single submit event on a form than it is to handle both click on button and enter keydown on input
|
✔️ Deploy Preview for vuejs ready! 🔨 Explore the source changes: 697df43 🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs/deploys/623212c477edc80008462f46 😎 Browse the preview: https://deploy-preview-1592--vuejs.netlify.app |
WickyNilliams
changed the title
NataliaTepluhina
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
@WickyNilliams thank you, submit event is more semantic indeed
|
No worries, thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
these tutorial step teach a bad practice, and is more complex than necessary as a result
Proposed Solution
it's easier, and more accessible, to handle a single submit event on a form than it is to handle both click on button and enter keydown on input. so switch to that instead
Additional Information
n/a